Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AC03D200CA4 for ; Wed, 7 Jun 2017 18:11:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AA943160BD0; Wed, 7 Jun 2017 16:11:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F051F160BB6 for ; Wed, 7 Jun 2017 18:11:58 +0200 (CEST) Received: (qmail 94763 invoked by uid 500); 7 Jun 2017 16:11:58 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 94738 invoked by uid 99); 7 Jun 2017 16:11:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 16:11:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 96735C02D2 for ; Wed, 7 Jun 2017 16:11:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ABrA-Ym3f0-a for ; Wed, 7 Jun 2017 16:11:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E10FA5F6BF for ; Wed, 7 Jun 2017 16:11:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v57GBuEQ018216; Wed, 7 Jun 2017 16:11:56 GMT Message-Id: <201706071611.v57GBuEQ018216@ip-10-146-233-104.ec2.internal> Date: Wed, 7 Jun 2017 16:11:56 +0000 From: "Laurel Hale (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: John Russell , Alex Behm Reply-To: laurel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4107_=5BDOCS=5D_APPX_MEDIAN_cuts_string_to_10_chars=0A?= X-Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 21ee3173ef613a59d8dcd1e00153cfc087178224 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 07 Jun 2017 16:11:59 -0000 Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars ...................................................................... Patch Set 3: (2 comments) > Thanks a lot for change. It's ok for me. Thanks, Peter! http://gerrit.cloudera.org:8080/#/c/7094/2/docs/topics/impala_appx_median.xml File docs/topics/impala_appx_median.xml: Line 76: > remove whitespace I think this white space is an artifact of Gerrit. It doesn't appear in the source XML. Line 78: The APPX_MEDIAN function returns only the first 10 characters for > string,varchar,char Done -- To view, visit http://gerrit.cloudera.org:8080/7094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-Reviewer: Peter Brejcak Gerrit-HasComments: Yes