Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 73633200C8C for ; Tue, 6 Jun 2017 20:20:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71DCD160BC6; Tue, 6 Jun 2017 18:20:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8C8D160BB7 for ; Tue, 6 Jun 2017 20:20:46 +0200 (CEST) Received: (qmail 4585 invoked by uid 500); 6 Jun 2017 18:20:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 4574 invoked by uid 99); 6 Jun 2017 18:20:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 18:20:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3F3421802C9 for ; Tue, 6 Jun 2017 18:20:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id felLIqpRLE0R for ; Tue, 6 Jun 2017 18:20:44 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B62EF5F254 for ; Tue, 6 Jun 2017 18:20:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v56IKg3P023263; Tue, 6 Jun 2017 18:20:42 GMT Message-Id: <201706061820.v56IKg3P023263@ip-10-146-233-104.ec2.internal> Date: Tue, 6 Jun 2017 18:20:42 +0000 From: "Impala Public Jenkins (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5282=3A_Handle_overflows_in_computeResourceProfile=28=29=2E=0A?= X-Gerrit-Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 227a180ab927c485f24663600114af0157d69450 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 06 Jun 2017 18:20:47 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5282: Handle overflows in computeResourceProfile(). ...................................................................... IMPALA-5282: Handle overflows in computeResourceProfile(). An overflow in computeResourceProfile() could lead to negative resource estimates which later lead to a failed Preconditions check. I went through the computeResourceProfile() implementation of all data sinks and plan nodes and changed the code to handle overflows. Testing: - Reproduced the issue locally with the DDL provided in the JIRA. I manually set huge NDV stats to trigger overflow. Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Reviewed-on: http://gerrit.cloudera.org:8080/7084 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/ExchangeNode.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java M fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java M fe/src/main/java/org/apache/impala/planner/JoinNode.java M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/SubplanNode.java M fe/src/main/java/org/apache/impala/planner/UnionNode.java 8 files changed, 19 insertions(+), 17 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a83a76141853d3274f812e5a531f456e1b110b1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong