Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D8C4E200C8C for ; Tue, 6 Jun 2017 19:32:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D7444160BC6; Tue, 6 Jun 2017 17:32:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A9C5160BB7 for ; Tue, 6 Jun 2017 19:32:19 +0200 (CEST) Received: (qmail 80990 invoked by uid 500); 6 Jun 2017 17:32:18 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 80978 invoked by uid 99); 6 Jun 2017 17:32:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 17:32:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AD83DCFEB5 for ; Tue, 6 Jun 2017 17:32:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KE3_nEPOWUHa for ; Tue, 6 Jun 2017 17:32:17 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id F30EC5F242 for ; Tue, 6 Jun 2017 17:32:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v56HWGmv021069; Tue, 6 Jun 2017 17:32:16 GMT Message-Id: <201706061732.v56HWGmv021069@ip-10-146-233-104.ec2.internal> Date: Tue, 6 Jun 2017 17:32:16 +0000 From: "Dimitris Tsirogiannis (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: dtsirogiannis@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5056=3A_Ensure_analysis_uses_=27fresh=27_catalog_after_metadata_loading=0A?= X-Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f X-Gerrit-ChangeURL: X-Gerrit-Commit: df869e5840a83e6cccb1d641d109d95c5ad2d014 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 06 Jun 2017 17:32:20 -0000 Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7045/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: PS4, Line 553: ImpaladCatalog catalog = impaladCatalog_.get(); nit: move this above L549 and use 'catalog' in both if and else blocks. PS4, Line 927: Preconditions.checkNotNull(analysisCtx); Don't think this is needed anymore. -- To view, visit http://gerrit.cloudera.org:8080/7045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: Yes