Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 12522200CAD for ; Tue, 6 Jun 2017 06:45:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1112D160BE1; Tue, 6 Jun 2017 04:45:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 57EC5160BD4 for ; Tue, 6 Jun 2017 06:45:47 +0200 (CEST) Received: (qmail 6239 invoked by uid 500); 6 Jun 2017 04:45:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6228 invoked by uid 99); 6 Jun 2017 04:45:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 04:45:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D3BF5C3205 for ; Tue, 6 Jun 2017 04:45:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZhS9a1ETZpgo for ; Tue, 6 Jun 2017 04:45:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8CDE75FDEE for ; Tue, 6 Jun 2017 04:45:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v564jg9Y009185; Tue, 6 Jun 2017 04:45:43 GMT Message-Id: <201706060445.v564jg9Y009185@ip-10-146-233-104.ec2.internal> Date: Tue, 6 Jun 2017 04:45:42 +0000 From: "Henry Robinson (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Juan Yu , Alan Choi , Tim Armstrong , Dan Hecht Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5388=3A_Only_retry_RPC_on_lost_connection_in_send_call=0A?= X-Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b X-Gerrit-ChangeURL: X-Gerrit-Commit: f3ee86b243b9ee5f463997df37f5c8f046185640 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 06 Jun 2017 04:45:48 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7063/4/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: Line 188: strstr(e.what(), "Socket send returned 0.") != nullptr); > how do we know this last one is due to a dropped connection? Reopen() should cycle the TCP connection underneath: Thrift on the server should then abandon the first recv(), accept a new connection and handle the repeated RPC in a new context. -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Alan Choi Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes