Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E6551200CAD for ; Tue, 6 Jun 2017 03:07:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E4D57160BE1; Tue, 6 Jun 2017 01:07:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36D26160BD4 for ; Tue, 6 Jun 2017 03:07:24 +0200 (CEST) Received: (qmail 464 invoked by uid 500); 6 Jun 2017 01:07:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 453 invoked by uid 99); 6 Jun 2017 01:07:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jun 2017 01:07:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B8700C0040 for ; Tue, 6 Jun 2017 01:07:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gBvMuy-s2y3g for ; Tue, 6 Jun 2017 01:07:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3B66C5F36F for ; Tue, 6 Jun 2017 01:07:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v5617JeQ002531; Tue, 6 Jun 2017 01:07:19 GMT Message-Id: <201706060107.v5617JeQ002531@ip-10-146-233-104.ec2.internal> Date: Tue, 6 Jun 2017 01:07:19 +0000 From: "Alex Behm (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: anujphadke Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5438=3A_Always_eval_union_const_exprs_in_subplan=2E=0A?= X-Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 X-Gerrit-ChangeURL: X-Gerrit-Commit: 20bd7a3a5e3708b822e2b1960da00dc9b98d58f7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 06 Jun 2017 01:07:25 -0000 Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-5438: Always eval union const exprs in subplan. ...................................................................... IMPALA-5438: Always eval union const exprs in subplan. The bug was that the constant exprs of a union were only evaluated for the first fragment instance. However, for a union inside a subplan, we should always evaluate the constant exprs. Testing: - Added a regression test. - Locally ran test_nested_types.py and the union tests in test_queries.py Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 --- M be/src/exec/union-node.cc M be/src/exec/union-node.h M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test 3 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/7091/2 -- To view, visit http://gerrit.cloudera.org:8080/7091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: anujphadke