Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 720FE200C7C for ; Mon, 5 Jun 2017 23:31:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 70C12160BBB; Mon, 5 Jun 2017 21:31:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6540160BD4 for ; Mon, 5 Jun 2017 23:31:14 +0200 (CEST) Received: (qmail 74695 invoked by uid 500); 5 Jun 2017 21:31:14 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74683 invoked by uid 99); 5 Jun 2017 21:31:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2017 21:31:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4F1A91A0389 for ; Mon, 5 Jun 2017 21:31:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id szrgHS5QcEBG for ; Mon, 5 Jun 2017 21:31:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2C2DB5FDEE for ; Mon, 5 Jun 2017 21:31:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v55LVAEi021092; Mon, 5 Jun 2017 21:31:10 GMT Message-Id: <201706052131.v55LVAEi021092@ip-10-146-233-104.ec2.internal> Date: Mon, 5 Jun 2017 21:31:10 +0000 From: "Lars Volker (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Jim Apple , Taras Bobrovytsky Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3643/IMPALA-5344=3A_Fix_FE_tests_on_Java_8=0A?= X-Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5782c986fb81dc3aa0d9e61a3046bb82fb73d89a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 05 Jun 2017 21:31:15 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7073/2/fe/src/main/java/org/apache/impala/analysis/SortInfo.java File fe/src/main/java/org/apache/impala/analysis/SortInfo.java: Line 193: Set sourceSlots = Sets.newLinkedHashSet(); > We should add a comment that points out that using LinkedHashSets prevents Done http://gerrit.cloudera.org:8080/#/c/7073/4/testdata/workloads/functional-planner/queries/PlannerTest/lineage.test File testdata/workloads/functional-planner/queries/PlannerTest/lineage.test: Line 35: "vertexId":"functional.alltypes.tinyint_col" > Do we know why the order changes in this file? Various places in ColumnLineageGraph.java iterated over HashSets. I changed those to LinkedHashSets to make the iteration order deterministic and consistent between Java 7 and Java 8, which changed the order here. -- To view, visit http://gerrit.cloudera.org:8080/7073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes