Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 63AFA200C7C for ; Mon, 5 Jun 2017 22:19:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6256A160BE1; Mon, 5 Jun 2017 20:19:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A98EA160BD4 for ; Mon, 5 Jun 2017 22:19:10 +0200 (CEST) Received: (qmail 19564 invoked by uid 500); 5 Jun 2017 20:19:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 19533 invoked by uid 99); 5 Jun 2017 20:19:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2017 20:19:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 44DEFCF651 for ; Mon, 5 Jun 2017 20:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JbuxnvZjFRcr for ; Mon, 5 Jun 2017 20:19:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4C29D5FC84 for ; Mon, 5 Jun 2017 20:19:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v55KJ3dl017871; Mon, 5 Jun 2017 20:19:03 GMT Message-Id: <201706052019.v55KJ3dl017871@ip-10-146-233-104.ec2.internal> Date: Mon, 5 Jun 2017 20:19:03 +0000 From: "Lars Volker (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Tim Armstrong Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5031=3A_Remove_undefined_behavior_=22reference_binding_to_null=22=0A?= X-Gerrit-Change-Id: Ifef5c3de686318bff4eac7dfad6e1639ddadb8f2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7d1bc9e191d7b90903164c999fa7558c916b94a5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 05 Jun 2017 20:19:11 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7008/4/be/src/exec/parquet-column-stats.inline.h File be/src/exec/parquet-column-stats.inline.h: PS4, Line 74: bytes_needed > 0 > how can bytes_needed be 0? when does that happen? Yes, this has to be > 0. I'm not sure a DCHECK prevents the compiler from inferring UB in release builds, so we may need the additional check. Adding a DCHECK would still be a good idea. -- To view, visit http://gerrit.cloudera.org:8080/7008 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifef5c3de686318bff4eac7dfad6e1639ddadb8f2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes