Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DBF9B200C7C for ; Mon, 5 Jun 2017 22:14:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DA8DB160BD4; Mon, 5 Jun 2017 20:14:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D4C6160BBB for ; Mon, 5 Jun 2017 22:14:01 +0200 (CEST) Received: (qmail 6539 invoked by uid 500); 5 Jun 2017 20:13:58 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6528 invoked by uid 99); 5 Jun 2017 20:13:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2017 20:13:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DB0E9C0040 for ; Mon, 5 Jun 2017 20:13:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vBjWxAm5L5i0 for ; Mon, 5 Jun 2017 20:13:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E27A65F5B9 for ; Mon, 5 Jun 2017 20:13:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v55KDtkX017550; Mon, 5 Jun 2017 20:13:55 GMT Message-Id: <201706052013.v55KDtkX017550@ip-10-146-233-104.ec2.internal> Date: Mon, 5 Jun 2017 20:13:55 +0000 From: "Marcel Kornacker (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5347=3A_reduce_codegen_overhead_of_timestamp_trunc=28=29=0A?= X-Gerrit-Change-Id: I222258f51b2093a38929df847fdb5d25bb9aafc3 X-Gerrit-ChangeURL: X-Gerrit-Commit: be2deaf972039c639479011f639643667a633712 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 05 Jun 2017 20:14:02 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc() ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7081/2/be/src/exprs/udf-builtins.cc File be/src/exprs/udf-builtins.cc: Line 16: // under the License. mention somewhere that these functions should specifically not get cross-compiled (otherwise the next person might decide there's something to be gained from ...). -- To view, visit http://gerrit.cloudera.org:8080/7081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I222258f51b2093a38929df847fdb5d25bb9aafc3 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes