Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 214FE200C7C for ; Mon, 5 Jun 2017 22:01:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1FF42160BD4; Mon, 5 Jun 2017 20:01:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 66E51160BBB for ; Mon, 5 Jun 2017 22:01:35 +0200 (CEST) Received: (qmail 65294 invoked by uid 500); 5 Jun 2017 20:01:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 65283 invoked by uid 99); 5 Jun 2017 20:01:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Jun 2017 20:01:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 05F80C0040 for ; Mon, 5 Jun 2017 20:01:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ed9XM876yjWo for ; Mon, 5 Jun 2017 20:01:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A365C5FB4E for ; Mon, 5 Jun 2017 20:01:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v55K1VOn016728; Mon, 5 Jun 2017 20:01:31 GMT Message-Id: <201706052001.v55K1VOn016728@ip-10-146-233-104.ec2.internal> Date: Mon, 5 Jun 2017 20:01:31 +0000 From: "Lars Volker (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Marcel Kornacker , Thomas Tauber-Marshall , Attila Jeges Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5357=3A_Fix_unixtime_to_UTC_TimestampValue_perf=0A?= X-Gerrit-Change-Id: I9d611d21310c7b4f93d8e0bc845eb85125abcac9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 32c03ad55eff2e130c3e0c6fc697515d58760460 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 05 Jun 2017 20:01:36 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf ...................................................................... Patch Set 1: Does this change need to bump the toolchain version to pull in the boost patch? -- To view, visit http://gerrit.cloudera.org:8080/7082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d611d21310c7b4f93d8e0bc845eb85125abcac9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: No