Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 674DC200CA9 for ; Fri, 2 Jun 2017 02:53:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 65E27160BDF; Fri, 2 Jun 2017 00:53:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AC144160BC4 for ; Fri, 2 Jun 2017 02:53:21 +0200 (CEST) Received: (qmail 83000 invoked by uid 500); 2 Jun 2017 00:53:20 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 82983 invoked by uid 99); 2 Jun 2017 00:53:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2017 00:53:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 49576188439 for ; Fri, 2 Jun 2017 00:53:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id yUM1UrX6j1aY for ; Fri, 2 Jun 2017 00:53:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 29FC25FDDC for ; Fri, 2 Jun 2017 00:53:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v520rInH014971; Fri, 2 Jun 2017 00:53:18 GMT Message-Id: <201706020053.v520rInH014971@ip-10-146-233-104.ec2.internal> Date: Fri, 2 Jun 2017 00:53:18 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Dimitris Tsirogiannis Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5056=3A_Ensure_analysis_uses_=27fresh=27_catalog_after_metadata_loading=0A?= X-Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f X-Gerrit-ChangeURL: X-Gerrit-Commit: df73f583b42c85847e23b36e7015945b12fe31cf In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 02 Jun 2017 00:53:22 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-5056: Ensure analysis uses 'fresh' catalog after metadata loading ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7045/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: Line 901: analysisCtx = new AnalysisContext(impaladCatalog_.get(), queryCtx, > Doesn't this destroy the analysisCtx.timeline_ and effectively hide how lon Ugh, I think you're right. But I don't think we want to put the atomic ref into the analysisctx - we don't want to read two different catalogs at different points during analysis by dereferencing the atomic ref at different times. Probably needs AnalysisContext.setCatalog() or similar. -- To view, visit http://gerrit.cloudera.org:8080/7045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574d69fa75198499523dc291fbbd0d7e3d8d968f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: Yes