impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
Date Wed, 28 Jun 2017 19:06:03 GMT
Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7321

Change subject: IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary
......................................................................

IMPALA-5595: Only set KuduScanner timestamp feature flag if necessary

To support Kudu timestamps, Impala sets a KuduScanner flag
which pads the result tuples:
KuduScanner::PAD_UNIXTIME_MICROS_TO_16_BYTES

It is always set, which is correct, but means that newer
versions of Impala cannot scan older Kudus even if there are
no TIMESTAMP columns.

Even though Impala provides no guarantees about supporting
older versions of Kudu (i.e. there is no testing), the flag
should just be set when there are TIMESTAMP columns since
this is a known incompatibility that is easy to work around
for users who are still willing to use unsupported setups.

Testing:
This works against the current version of Kudu (the only
supported configuration).

Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
---
M be/src/exec/kudu-scanner.cc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/7321/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5a83d2a6db97812295e6e8d37c274fe1f1dc3fb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message