impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5591: set should handle negative values
Date Wed, 28 Jun 2017 16:44:17 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7316

Change subject: IMPALA-5591: set should handle negative values
......................................................................

IMPALA-5591: set should handle negative values

The parser didn't account for the possibility of negative
numeric literals.

Testing:
Added a test that sets a negative value. Query tests send the whole
"set" statement to the backend for execution so exercise the parser.

Ran core tests.

Change-Id: I5c415dbed6ba1122919be75f5811444d88ee03b4
---
M fe/src/main/cup/sql-parser.cup
M testdata/workloads/functional-query/queries/QueryTest/set.test
2 files changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7316/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c415dbed6ba1122919be75f5811444d88ee03b4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message