impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5588: RPC end to end tests: protect against eval of None
Date Tue, 27 Jun 2017 21:24:05 GMT
Michael Brown has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7308

Change subject: IMPALA-5588: RPC end to end tests: protect against eval of None
......................................................................

IMPALA-5588: RPC end to end tests: protect against eval of None

When running a query in the RPC exceptions test suite, if the query
fails, the query's failure message is evaluated against possible
expected exception strings. However in some case the expected_exception
variable is None. A variable set to None can't be used in an 'in'
expression, leading to a TypeError.

This patch examines expected_exception: if None, assume no exception
should be raised, so we should re-raise the caught exception. Only
compare against the caught exception's string when we expect to do so.

Testing:

- ran this suite's tests locally

Change-Id: I2708c91258e9604fc172eaba155d1640abc04aa8
---
M tests/custom_cluster/test_rpc_exception.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/7308/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2708c91258e9604fc172eaba155d1640abc04aa8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>

Mime
View raw message