impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers
Date Wed, 21 Jun 2017 00:57:13 GMT
Zach Amsden has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7240

Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers
......................................................................

IMPALA-5548 Fix some minor issues with HDFS / parquet column readers

Replace some std::map instances with unordered maps.  std::map is
unnecessary in many cases where an unordered map should suffice, and in
almost all circumstances, perform better.  Also discovered was a
slightly dangerous initialization of an empty NullOffsetIndicator, which
could conceivably result in undefined behavior by writing arr[ofs] |= b,
where ofs was mistakenly initialized to -1 (and b to 0, so such behavior
may not be detected, but could cause a crash by underrunning a buffer).

Testing: Running exhaustive tests against a Jenkins build.

Change-Id: I08e653cae6f2188599f4a23e4f44692166d9c119
---
M be/src/exec/hdfs-scan-node-base.cc
M be/src/exec/hdfs-scan-node-base.h
M be/src/exec/hdfs-scanner.h
M be/src/exec/parquet-column-readers.h
M be/src/runtime/descriptors.h
5 files changed, 12 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/7240/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08e653cae6f2188599f4a23e4f44692166d9c119
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message