impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5240: Allow configuration of number of disk I/O threads based on disk type
Date Tue, 20 Jun 2017 18:42:05 GMT
Bikramjeet Vig has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7232

Change subject: IMPALA-5240: Allow configuration of number of disk I/O threads based on disk
type
......................................................................

IMPALA-5240: Allow configuration of number of disk I/O threads based
on disk type

Currently Impala defaults to 8 threads per flash disk and 1 thread per
rotational disk. This can be overridden with --num_threads_per_disk,
but that sets the thread count independent of disk type.

This would allow control of the number of disk I/O threads spawned
independently for flash disks using "--num_threads_per_flash_disk"
and for rotational disks using "--num_threads_per_rotational_disk"
as startup parameters.

Testing:
Tested manually. Unfortunately, there is no way using DiskIoMgr class
to confirm these variables were set, therefore no automated backend
tests were added.

Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c
---
M be/src/runtime/disk-io-mgr.cc
M be/src/runtime/disk-io-mgr.h
M fe/src/test/java/org/apache/impala/testutil/SentryServicePinger.java
3 files changed, 36 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/7232/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>

Mime
View raw message