impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5031: Don't dereference uninitialized memory as a bool.
Date Sun, 11 Jun 2017 17:07:52 GMT
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7148

Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
......................................................................

IMPALA-5031: Don't dereference uninitialized memory as a bool.

Every bool takes up a byte of memory, but not every byte of memory is
a valid bool. Dereferencing that memory, even if only to write to, it
is undefined behavior.

Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224
Testing: running exhaustive UBSAN and DEBUG.
---
M be/src/runtime/raw-value.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/7148/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc03401a9aeb966f33298268e53ab1040d007224
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>

Mime
View raw message