impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Date Thu, 08 Jun 2017 15:22:59 GMT
Michael Brown has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7115

Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds
......................................................................

IMPALA-3040 addendum: use specific_build_type_timeout for slow builds

IMPALA-3040 was initially fixed to use a timeout with HDFS caching
tests, however some test executions against slow-running builds such as
ASAN indicate this timeout may not be high enough.

Use the specific_build_type_timeout() method to set a much higher
timeout for slower builds such as ASAN. This allows us to virtually
ignore timeout values on slow builds, but doesn't force us to
undconditionally increase the timeout in a release or debug build.

Testing:

Ran all tests that use get_num_cache_requests() in a loop 100 times each
under an ASAN build.  All test iterations passed.

Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
---
M tests/query_test/test_hdfs_caching.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/7115/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>

Mime
View raw message