impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5384: Simplify coordinator locking protocol
Date Fri, 02 Jun 2017 21:46:19 GMT
Marcel Kornacker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7065

Change subject: IMPALA-5384: Simplify coordinator locking protocol
......................................................................

IMPALA-5384: Simplify coordinator locking protocol

This changes the locking behavior of the coordinator in
the following way:
- the central lock_ is replaced with a state variable
  protected by a lock; the state distinguishes between
  execution and (multiple) error states and is used
  to maintain the overall query status
- data structures related to stats about Insert operations
  are moved into a new class InsertExecState

Also:
- adds DescriptorTbl::CreateHdfsTableDescriptor to avoid
  having to create an entire DescriptorTbl during INSERT
  finalization (when only a descriptor for the output
  table is needed)
- removes TQueryExecRequest.desc_tbl, there's already
  a home for it in TQueryContext.desc_tbl

Change-Id: I6a79aa38e529d0994921906b2beb796fd589a7e3
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/exec/catalog-op-executor.cc
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/hbase-table-sink.cc
M be/src/exec/hdfs-table-sink.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/plan-root-sink.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/descriptors.cc
M be/src/runtime/descriptors.h
M be/src/runtime/fragment-instance-state.cc
A be/src/runtime/insert-exec-state.cc
A be/src/runtime/insert-exec-state.h
M be/src/runtime/query-state.cc
M be/src/runtime/runtime-filter-bank.cc
M be/src/runtime/runtime-state.h
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M be/src/testutil/in-process-servers.cc
M be/src/util/counting-barrier.h
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java
33 files changed, 1,140 insertions(+), 935 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/7065/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a79aa38e529d0994921906b2beb796fd589a7e3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message