impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5388: Don't retry RPC calls on TSSLException
Date Fri, 02 Jun 2017 18:21:43 GMT
Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7063

Change subject: IMPALA-5388: Don't retry RPC calls on TSSLException
......................................................................

IMPALA-5388: Don't retry RPC calls on TSSLException

Our RPC implementation would retry the RPC once if the first
invocation fails. The reasoning, as far as I understand, is
that the connection may have been closed so the retry logic
will reopen the connection and do the RPC call again. However,
with TLS enabled, the existing code will misinterpret TSSLException
as a lost connection and retry the RPC. TSSLException may be
thrown in both the send and recv RPC calls so it may occur
that the send may have suceeded already and resending the RPC
is not safe. As shown in IMPALA-5388, it can lead to wrong
query results.

This change fixes the problem by unconditionally returning
RPC_GENERAL_ERROR to the caller on TSSLException and don't
retry the RPC call.

Testing: Michael Brown will re-run the stress test in the secure
cluster. He's currently facing some deployment issue with CM and
cannot make much progress.

Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b
---
M be/src/runtime/client-cache.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/7063/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
View raw message