impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5381: Adds DEFAULT JOIN STRATEGY query option.
Date Fri, 02 Jun 2017 17:52:07 GMT
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7059

Change subject: IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option.
......................................................................

IMPALA-5381: Adds DEFAULT_JOIN_STRATEGY query option.

Adds a new query option DEFAULT_JOIN_STRATEGY to control
which join strategy is chosen when the join inputs have
an unknown cardinality (e.g., missing stats) or when
the expected costs of the different strategies are equal.

Values for DEFAULT_JOIN_STRATEGY: [BROADCAST, SHUFFLE]
Default: BROADCAST

Note that this change effectively undoes IMPALA-5120.

Testing:
- Added new planner tests
- Core/hdfs run passed

Change-Id: Ibd34442f422129d53bef5493fc9cbe7375a0765c
---
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M common/thrift/ImpalaService.thrift
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/default-join-strategy-broadcast.test
A testdata/workloads/functional-planner/queries/PlannerTest/default-join-strategy-shuffle.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
9 files changed, 237 insertions(+), 88 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/7059/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd34442f422129d53bef5493fc9cbe7375a0765c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>

Mime
View raw message