impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Behm <alex.b...@cloudera.com>
Subject Re: [Impala-ASF-CR] IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
Date Mon, 12 Jun 2017 20:33:38 GMT
Congratulations on your first commit, Yu! Thanks for your contribution.
Great work on getting this through design and code review!

On Mon, Jun 12, 2017 at 1:31 PM, Impala Public Jenkins (Code Review) <
gerrit@cloudera.org> wrote:

> Impala Public Jenkins has submitted this change and it was merged.
>
> Change subject: IMPALA-5016: Simplify COALESCE() in
> SimplifyConditionalsRule.
> ......................................................................
>
>
> IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
>
> Simplify COALESCE by skipping leading nulls and applying the following
> transformations:
> COALESCE(null, a, b) -> COALESCE(a, b);
> COALESCE(<literal>, a, b) -> <literal>, when literal is not NullLiteral;
> COALESCE(<partition-slotref>, a, b) -> <partition-slotref>,
> when the partition column does not contain NULL.
>
> Testing:
> added unit tests in ExprRewriteRulesTest
>
> Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
> Reviewed-on: http://gerrit.cloudera.org:8080/7015
> Reviewed-by: Alex Behm <alex.behm@cloudera.com>
> Tested-by: Impala Public Jenkins
> ---
> M fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
> M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
> 2 files changed, 126 insertions(+), 17 deletions(-)
>
> Approvals:
>   Impala Public Jenkins: Verified
>   Alex Behm: Looks good to me, approved
>
>
>
> --
> To view, visit http://gerrit.cloudera.org:8080/7015
> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>
> Gerrit-MessageType: merged
> Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
> Gerrit-PatchSet: 7
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-Owner: yu feng <hzfengyu@corp.netease.com>
> Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
> Gerrit-Reviewer: Impala Public Jenkins
> Gerrit-Reviewer: yu feng <hzfengyu@corp.netease.com>
>
> --
> You received this message because you are subscribed to the Google Groups
> "impala-cr" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to impala-cr+unsubscribe@cloudera.com.
> For more options, visit https://groups.google.com/a/cloudera.com/d/optout.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message