impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
Date Fri, 30 Jun 2017 22:28:33 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5611: KuduPartitionExpr holds onto memory unnecessarily
......................................................................


Patch Set 3:

(2 comments)

> (2 comments)
 > 
 > nice! After this change, do you see that there isn't that much
 > memory accumulating in either the data sinks or in the sort?

yes

http://gerrit.cloudera.org:8080/#/c/7346/3//COMMIT_MSG
Commit Message:

PS3, Line 12: KuduPartitionExpr
> The DataStreamSender never frees the local allocations for the Kudu partiti
Done


PS3, Line 15: Since we only need the value of the row for the call into the Kudu
            : client, we can call FreeLocalAllocations after that.
> remove - we don't wanna do this per row
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia661eb8bed114070728a1497ccf7ed6893237e5e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message