impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins
Date Fri, 30 Jun 2017 04:09:48 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4674: Part 1: remove old aggs and joins
......................................................................


Patch Set 4:

(1 comment)

Looks good when the time is right. 

Maybe print something to the warning log if either flag is set to true?

http://gerrit.cloudera.org:8080/#/c/7102/4/be/src/exec/blocking-join-node.cc
File be/src/exec/blocking-join-node.cc:

Line 158:     *status = SendBuildInputToSink<true>(state, build_sink);
one line?


-- 
To view, visit http://gerrit.cloudera.org:8080/7102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ce2236d37c0ced188a4a81f7e00d4b8ac98e7e9
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message