impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs
Date Fri, 30 Jun 2017 03:07:52 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs
......................................................................


Patch Set 11: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7155/9/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

Line 122:   }
> Wait() deals with the latest status of WaitInternal, but as far as I could 
I was thinking UpdateQueryStatus() returns the query_status_ but that's not the case. Okay,
let's leave it alone for now. We really need to clean up the CRS / coordinator and related
class splits as they currently don't make much sense, but that's obviously out of scope for
this change.


http://gerrit.cloudera.org:8080/#/c/7155/11/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

Line 255:       !request_state->query_status().ok());
any reason not to make this stronger and have the implication go in both directions? 

DCHECK_EQ(query_state() == EXCEPTION, !query_status().ok())

isn't that what we want to guarantee (and what we do guarantee now)?


Line 293:         !request_state->query_status().ok());
same


-- 
To view, visit http://gerrit.cloudera.org:8080/7155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4494fe3f933cc23841db0e7da407eec5650f2b5
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message