impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5591: set should handle negative values
Date Wed, 28 Jun 2017 23:50:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5591: set should handle negative values
......................................................................


Patch Set 2:

-1 means "unlimited" for scratch_limit since 0 is a reasonable value. It's a bit unfortunate
that 0 is used to mean "unlimited" for some other query options.

The default value of scratch_limit is -1, so when it's overridden in a .test file it gets
automatically set back to -1 at the end of the test.

-- 
To view, visit http://gerrit.cloudera.org:8080/7316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415dbed6ba1122919be75f5811444d88ee03b4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message