impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size
Date Wed, 28 Jun 2017 19:07:25 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5500: Reduce catalog update topic size
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7268/7/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

Line 335:         pending_topic_updates_.pop_back();
I think we could incorrectly end up popping two pending topic updates here. One way to fix
it is to check status.ok() in L331


http://gerrit.cloudera.org:8080/#/c/7268/7/be/src/catalog/catalog-util.cc
File be/src/catalog/catalog-util.cc:

Line 202:   ReadWriteUtil::PutInt(output_buffer_ptr, (uint32_t)catalog_object->size());
static_cast instead of C-style cast


-- 
To view, visit http://gerrit.cloudera.org:8080/7268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message