impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5591: set should handle negative values
Date Wed, 28 Jun 2017 17:10:09 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5591: set should handle negative values
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7316/1/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

PS1, Line 2291: 	
I need to remove this tab.


PS1, Line 2291: KW_SET ident_or_default:key EQUAL SUBTRACT numeric_literal:l
> How about making changes in sql-scanner to accommodate -ve integer literals
I think that would make the grammar ambiguous (at least without other changes) since "-" is
also an operator, not just part of a literal. I.e. if "SUBTRACT expr" remains a rule, then
"-1" could be parsed as either "literal" or "SUBTRACT literal".


-- 
To view, visit http://gerrit.cloudera.org:8080/7316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c415dbed6ba1122919be75f5811444d88ee03b4
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message