impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size
Date Wed, 28 Jun 2017 00:15:28 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5500: Reduce catalog update topic size
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

Line 327:     vector<uint8_t> serialized_object;
> Unused variable?
Done


Line 334:       // Compress the catalog object
> remove (same as code)
Done


Line 358:   RETURN_IF_ERROR(Codec::CreateCompressor(nullptr, false, THdfsCompression::SNAPPY,
> I see - we're depending on MaxOutputLen() on the decompression path. Can't 
I am hesitant to do that. We need essentially to populate the TopicItem with an additional
field that is only catalog specific. Also, we already get a 4x compression of catalog topic
updates, so I am wondering if this is really worth it. Not super familiar with LZ4's performance/compression
ratio. Is it significantly better?


Line 367:   compressed_data.resize(result_len);
> remove
Done


http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS5, Line 1293: reinterpret_cast<const uint8_t*>(
> Is this cast needed? vector<uint8_t>.data() should return uint8_t*.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message