impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size
Date Tue, 27 Jun 2017 21:04:09 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5500: Reduce catalog update topic size
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7268/4/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

Line 328:     Status status = thrift_serializer_.Serialize(&catalog_object, &serialized_object);
Let's try to avoid the extra copy for the !FLAGS_compact_catalog_topic case. I think you could
pass in &item.value to Serialize like before, and then change CompressCatalogObject()
to take a const uint8_t* and a length as input.


-- 
To view, visit http://gerrit.cloudera.org:8080/7268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message