impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size
Date Tue, 27 Jun 2017 18:28:53 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5500: Reduce catalog update topic size
......................................................................


Patch Set 3:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/7268/3/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

Line 331:       status = SerializeAndCompressCatalogObject(catalog_object, item);
> Thinking we should have a similar separation of serialization and compressi
Done


Line 366:   compressed_buffer.resize(result_len);
> Remove since we're copying into item.value anyway
Done


Line 367:   item.value = string(reinterpret_cast<char*>(compressed_buffer_ptr),
> use item.value.assign()
Done


http://gerrit.cloudera.org:8080/#/c/7268/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 557:       std::vector<uint8_t>& data_buffer) WARN_UNUSED_RESULT;
> we use pointers for out params, i.e. use std::vector<uint8_t>*
Done


http://gerrit.cloudera.org:8080/#/c/7268/3/be/src/util/compress.h
File be/src/util/compress.h:

Line 113
> revert
Done


http://gerrit.cloudera.org:8080/#/c/7268/3/be/src/util/decompress.h
File be/src/util/decompress.h:

Line 86: 
> revert
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f725cd8596205e6101d5b56abf08125faa30b0a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message