impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5571: Fix authorization tests
Date Mon, 26 Jun 2017 23:46:31 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5571: Fix authorization tests
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7299/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 2919:     } else if (updatedPrivs.size() > 1) {
This is more of a question than a comment. I know this is the behavior prior to your patch(IMPALA-5549)
but what exactly prevents the processing/applying of multiple privileges in the coordinator/fe?
Had a quick look at the code and ProcessCatalogUpdateResult() and updateCatalog() calls seems
to handle multiple updated objects fine? Is something else causing the problem?


-- 
To view, visit http://gerrit.cloudera.org:8080/7299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icad893a10fdeb7a721264e69413014603dec6339
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message