impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5431: Remove redundant path exists checks during table load
Date Mon, 26 Jun 2017 23:26:23 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5431: Remove redundant path exists checks during table load
......................................................................


Patch Set 7: Code-Review+2

(3 comments)

Carrying +2.

http://gerrit.cloudera.org:8080/#/c/7095/5/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

PS5, Line 302: RemoteIterator<LocatedFileStatus> fileStatusIter =
> nit: move it below L305. If we're going to return there is no need to get a
Done


PS5, Line 727: DataFile(fileStatus)) continue;
> newFileDescs?
Done. Rewrote a little.


http://gerrit.cloudera.org:8080/#/c/7095/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

Line 498:       return fs.listStatus(p);
> I am thinking maybe add a warn in the log that the path doesn't exist.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message