impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5431: Remove redundant path exists checks during table load
Date Mon, 26 Jun 2017 22:58:21 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5431: Remove redundant path exists checks during table load
......................................................................


Patch Set 6:

- Updated the commit message with benchmark numbers. 

- Also, looks like CTAS analysis is likely a non-issue (also discussed with Alex offline)
since the "create" part of CTAS results in creation of base directory for table (by HMS) and
we always inherit correct ACLs of parent and the case that the table directory doesn't exist
is not possible. 

- Ran the following test to confirm that.

➜  Impala git:(i5431) ✗ hadoop fs -setfacl -m  user:bharath:rw- /tmp/foo
➜  Impala git:(i5431) ✗ hadoop fs -getfacl /tmp/foo
# file: /tmp/foo
# owner: bharath
# group: supergroup
user::rwx
user:bharath:rw-
group::r-x
mask::rwx
other::r-x

[localhost:21000] > create table bar location '/tmp/foo/bar' as select * from tpch_parquet.nation;
Query: create table bar location '/tmp/foo/bar' as select * from tpch_parquet.nation
Query submitted at: 2017-06-26 15:55:28 (Coordinator: http://optimus:25000)
Query progress can be monitored at: http://optimus:25000/query_plan?query_id=8d4f60928bebcc9c:f7e2c92f00000000
+--------------------+
| summary            |
+--------------------+
| Inserted 25 row(s) |
+--------------------+

[localhost:21000] > select count(*) from bar;
Query: select count(*) from bar
Query submitted at: 2017-06-26 15:55:44 (Coordinator: http://optimus:25000)
Query progress can be monitored at: http://optimus:25000/query_plan?query_id=8e44ede23419d848:afac511600000000
+----------+
| count(*) |
+----------+
| 25       |
+----------+

➜  Impala git:(i5431) ✗ hadoop fs -getfacl /tmp/foo/bar
# file: /tmp/foo/bar
# owner: bharath
# group: supergroup
user::rwx
user:bharath:rw-
group::rwx
mask::rwx
other::r-x

-- 
To view, visit http://gerrit.cloudera.org:8080/7095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message