impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5567: race in fragment instance teardown
Date Mon, 26 Jun 2017 21:24:36 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5567: race in fragment instance teardown

Patch Set 1:

File be/src/exec/

Line 101:     results_ = nullptr;
> I don't feel strongly. I think the idea was to move these status checks mor
It doesn't seem strictly necessary for this change. Feel free to do it later.
File be/src/runtime/runtime-state.h:

PS1, Line 294:   /// Returns a non-OK status if query execution should stop (e.g., the query
             :   /// cancelled or a mem limit was exceeded). Exec nodes should check this
periodically so
             :   /// execution doesn't continue if the query terminates abnormally. This should
not be
             :   /// called after ReleaseResources().
             :   Status CheckQueryState();
> I think we should do the work of removing Allocate() calls at some point bu
Yes, I wasn't suggesting that we should convert those Allocate() to TryAllocate() in this
change. That's just something we can do to get rid of CheckQueryState() altogether.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: If567e734042b5f2b82323368dd536dbf3bdf4744
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message