impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4687: Get Impala working against HBase 2.0
Date Mon, 26 Jun 2017 20:05:18 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4687: Get Impala working against HBase 2.0
......................................................................


Patch Set 2: Code-Review+1

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7277/1/be/src/exec/hbase-table-scanner.cc
File be/src/exec/hbase-table-scanner.cc:

PS1, Line 197: setStartRow
> It turns out that setStartRow/setStopRow are newly deprecated. The new meth
Ok, thanks. Mind adding a TODO with jira reference?


PS1, Line 403: 
             : Status HBaseTableScanner::HandleResultS
> We need the actual jthrowable so that we can check whether it is an instanc
Yea, I missed that part, thanks


http://gerrit.cloudera.org:8080/#/c/7277/2/be/src/exec/hbase-table-scanner.cc
File be/src/exec/hbase-table-scanner.cc:

PS2, Line 411: error
nit: Don't think error is the right term here. GetJniExceptionMsg() can just return Status:OK()
as well.


http://gerrit.cloudera.org:8080/#/c/7277/1/be/src/exec/hbase-table-scanner.h
File be/src/exec/hbase-table-scanner.h:

PS1, Line 65: HBASE-17809.
            : ///    If ScannerTimeout
nit: Same comment as in the .cc file. We don't always throw an error, we can just pass if
there is no other exception. May be good to clear it up


-- 
To view, visit http://gerrit.cloudera.org:8080/7277
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87610e25c01b3547ec332c6975b61284b6837d27
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message