impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5558/IMPALA-5576: Reopen stale client connection
Date Mon, 26 Jun 2017 02:23:38 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5558/IMPALA-5576: Reopen stale client connection

Patch Set 10:

Commit Message:

Line 54: 
> can you mention the test coverage that has been completed?
File be/src/rpc/

PS10, Line 198: String take
> Strings taken?

PS10, Line 198: TSocker
> typo
File be/src/runtime/

PS10, Line 248:     if (instance_stats->done_) continue;
> It would be good to mention this fix in the commit message too.

PS10, Line 353: SleepForMs(100);
> Just wondering if it's a good idea to have the coordinator thread go to sle
Oops.. I missed the lock up there. Definitely we shouldn't sleep in this case. Sorry for missing
that and thanks for pointing that out.

PS10, Line 356: status_.MergeStatus(client_status);
> Isn't this redundant if you're adding its message as a detail below in L361
MergeStatus() is needed in case status_.msg_ is NULL. I agree that it's redundant to call
AddDetails() below though.

PS10, Line 365: status_.MergeStatus(rpc_status);
> Same here

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d722c8ad3bf0e78e89887b6cb286c69ca61b8f5
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-HasComments: Yes

View raw message