impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5558: Reopen stale client connection
Date Sat, 24 Jun 2017 22:04:31 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5558: Reopen stale client connection
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7284/7/be/src/testutil/fault-injection-util.cc
File be/src/testutil/fault-injection-util.cc:

PS7, Line 67:    if (send_count.Add(1) % freq == 0) {
            :       switch (xcp_type) {
            :         case RPC_EXCEPTION_SEND_LOST_CONNECTION:
            :           throw TTransportException(TTransportException::NOT_OPEN,
            :               "Called write on non-open socket");
            :         case RPC_EXCEPTION_SEND_TIMEDOUT:
            :           throw TTransportException(TTransportException::TIMED_OUT,
            :               "send timeout expired");
            :         case RPC_EXCEPTION_SSL_SEND_LOST_CONNECTION:
            :           throw TTransportException(TTransportException::NOT_OPEN);
            :         case RPC_EXCEPTION_SSL_SEND_TIMEDOUT:
            :           throw TSSLException("SSL_write: Resource temporarily unavailable");
            :         // fall through for the default case.
            :       }
            :     }
            :   } else {
            :     if (recv_count.Add(1) % freq == 0) {
            :       switch (xcp_type) {
            :         case RPC_EXCEPTION_RECV_LOST_CONNECTION:
            :           throw TTransportException(TTransportException::END_OF_FILE,
            :              "No more data to read.");
            :         case RPC_EXCEPTION_RECV_TIMEDOUT:
            :           throw TTransportException(TTransportException::TIMED_OUT,
            :               "EAGAIN (timed out)");
            :         case RPC_EXCEPTION_SSL_RECV_LOST_CONNECTION:
            :           throw TTransportException(TTransportException::NOT_OPEN);
            :         case RPC_EXCEPTION_SSL_RECV_TIMEDOUT:
            :           throw TSSLException("SSL_read: Resource temporarily unavailable");
            :         // fall through for the default case.
            :       }
            :     }
This needs to be updated.


http://gerrit.cloudera.org:8080/#/c/7284/7/tests/custom_cluster/test_rpc_exception.py
File tests/custom_cluster/test_rpc_exception.py:

Line 42: 
Tests here also need to be updated.


-- 
To view, visit http://gerrit.cloudera.org:8080/7284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d722c8ad3bf0e78e89887b6cb286c69ca61b8f5
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message