impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4687: Get Impala working against HBase 2.0
Date Fri, 23 Jun 2017 22:31:43 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4687: Get Impala working against HBase 2.0

Patch Set 1:

Commit Message:

PS1, Line 25: This was tested by verifying that an HBase 2.0 cluster
            : starts up.
I think we should run hbase stress test eventually to test the new ScannerTimeOutException
code paths as it is only retried during load.
File be/src/exec/

PS1, Line 238: 
May be retain this part.

PS1, Line 197: setStartRow
You mentioned on the jira that these are deprecated too (setStartRow/setStopRow), may be switch
to with*Row() methods now that we are here?

PS1, Line 403: jthrowable exc = env->ExceptionOccurred();
             :   if (exc == NULL) return Status::OK();
Unrelated to your change, but why are we calling this here? Shouldn't GetJniExceptionMsg()
do the same?

PS1, Line 407: simple
File be/src/exec/hbase-table-writer.h:

PS1, Line 108: add
File be/src/util/

Line 61:   env->GetMethodID(class_ref, method_str, method_signature);
Reading the documentation for "GetMethodID"

"Returns a method ID, or NULL if the specified method cannot be found."

Can't we just do a NULL check on GetMethodID() call?
File be/src/util/jni-util.h:

PS1, Line 171: a method
..non static method..

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I87610e25c01b3547ec332c6975b61284b6837d27
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-HasComments: Yes

View raw message