impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
Date Fri, 23 Jun 2017 18:49:55 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
......................................................................


Patch Set 6:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:

PS6, Line 1485: HashMap
> LinkedHashMap?
Done


PS6, Line 1528: Map
> LinkedHashMap?
Done


PS6, Line 1695:     
> LinkedHashMap?
Done


PS6, Line 1908: HashMap
> LinkedHashMap?
Done


http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java:

PS6, Line 444: Map
> LinkedHashMap? I don't feel as strongly about this one since it doesn't cro
Done


http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

Line 179:   // LinkeHashSet where applicable to preserve the iteration order and make the
class
> typo
Done


http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java
File fe/src/main/java/org/apache/impala/analysis/ColumnLineageGraph.java:

PS6, Line 171: getSources
> getOrderedSources()?
Done


PS6, Line 176: getTargets
> Maybe getOrderedTargets()?
Done


PS6, Line 194: Map
> LinkedHashMap?
Done


Line 342:     for (String target: Sets.newTreeSet(targets)) {
> It might be more efficient to use Guava's ImmutableSortedSet here and above
Done. Should we change this in other places in the file that we haven't touched so far?


http://gerrit.cloudera.org:8080/#/c/7073/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:

PS6, Line 187: HashMap
> LinkedHashMap?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message