impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
Date Fri, 23 Jun 2017 17:40:49 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
......................................................................


Patch Set 6:

Lars can obviously chime in but I'll give my rationale for the +1.

My understanding is we will stay at Java language compatibility level 7 but remove the dependency
of Impala tests on implementation-defined behaviour of Sun JDK 7. I think we should consider
that dependence on implementation-defined behaviour a bug. There are no guarantees about iteration
order in the Java spec and it could change at any point, e.g. in a JDK update or even between
different instances of HashMaps.

OpenJDK 7 is near EOL and Sun JDK 7 is EOL so if we don't fix this we'll soon be in a situation
where our tests only pass on obsolete JDKs.

This inconveniences me personally since I'm using OpenJDK 8 and in general it's unreasonable
to expect contributors to develop on obsolete JDKs.

-- 
To view, visit http://gerrit.cloudera.org:8080/7073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message