impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts
Date Thu, 22 Jun 2017 23:05:35 GMT
Matthew Jacobs has posted comments on this change.

Change subject: DRAFT - IMPALA-5498: Support for partial sorts
......................................................................


Patch Set 1:

(4 comments)

I think the interface changes make sense. I'm not digging into the code details much yet.

http://gerrit.cloudera.org:8080/#/c/7267/1/be/src/exec/partial-sort-node.h
File be/src/exec/partial-sort-node.h:

PS1, Line 30: a single tuple
can you clarify, this is a bit unclear


PS1, Line 34: If a merge phase was performed in the sort, sorted rows are deep copied into
            : /// the output batch.
I thought there wouldn't need to be a merge


http://gerrit.cloudera.org:8080/#/c/7267/1/common/thrift/PlanNodes.thrift
File common/thrift/PlanNodes.thrift:

PS1, Line 353:   2: required bool use_top_n;
this will move to TSortType, right?


PS1, Line 355: 3: optional i64 offset
I don't think we'll need to implement the behavior to support this for partial sorts, and
if we don't we should be clear about what this applies to: top N only I believe


-- 
To view, visit http://gerrit.cloudera.org:8080/7267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message