impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] DRAFT - IMPALA-5498: Support for partial sorts
Date Thu, 22 Jun 2017 21:52:20 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: DRAFT - IMPALA-5498: Support for partial sorts
......................................................................


Patch Set 1:

(2 comments)

I haven't looked much at the Planner changes needed, eg. in SortNode.computeResourceProfile,
but this patch gives a good idea of the interface changes needed.

http://gerrit.cloudera.org:8080/#/c/7267/1/be/src/exec/partial-sort-node.cc
File be/src/exec/partial-sort-node.cc:

Line 41: Status PartialSortNode::Init(const TPlanNode& tnode, RuntimeState* state) {
There's a lot of boiler plate here and in Prepare, Open, and Codegen that could be shared
with SortNode.


http://gerrit.cloudera.org:8080/#/c/7267/1/fe/src/main/java/org/apache/impala/planner/SortNode.java
File fe/src/main/java/org/apache/impala/planner/SortNode.java:

Line 65:   private final boolean useTopN_;
This will be replaced with TSortType.TOPN


-- 
To view, visit http://gerrit.cloudera.org:8080/7267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec2a15a0cc5240b1c13682067ab64670d1e0a38
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message