impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.
Date Thu, 22 Jun 2017 19:30:55 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5562: Only recomputeMemLayout() if tuple has a layout.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7264/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:

Line 245:         collSlotRef.getDesc().getParent().recomputeMemLayout();
> I thought to replace the Precondition with
Works for me either way. Switched to your suggestion.

If the query requires a tuple to have a mem layout, then that will be detected in toThrift()
of the plan, so I don't think the Preconditions check in recomputeMemLayout() would give us
any additional validation that we would not otherwise have.


-- 
To view, visit http://gerrit.cloudera.org:8080/7264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08548c6bfa7dbf4655e55636605bebb89d2a2239
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message