impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type
Date Wed, 21 Jun 2017 20:38:12 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7232/1/be/src/runtime/disk-io-mgr.h
File be/src/runtime/disk-io-mgr.h:

PS1, Line 637:   DiskIoMgr(int num_disks, int threads_per_disk, int min_buffer_size,
             :       int max_buffer_size);
             : 
             :   /// Create DiskIoMgr with default configs.
             :   DiskIoMgr();
             : 
             :   /// Clean up all threads and resour
> You can remove threads_per_disk and instead change the tests to pass the sa
Done


PS1, Line 637:   DiskIoMgr(int num_disks, int threads_per_disk, int min_buffer_size,
             :       int max_buffer_size);
             : 
             :   /// Create DiskIoMgr with default configs.
             :   DiskIoMgr();
             : 
             :   /// Clean up all threads and resour
> You can also change DiskQueue to know how many threads it has, and update D
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message