impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout
Date Wed, 21 Jun 2017 20:23:21 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout
......................................................................


IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout

A previous commit attempted to fix IMPALA-4868 by waiting
longer for a new file to become visible to the Impala code
responsible for parsing the admission control config file.
The timeout was observed in another gerrit-verify job, so we
should increase this timeout further. I don't see any
indication that there is anything else wrong with the test,
or that any other kind of failure occurred.

This change gives the test up to 20 seconds for the new file
to become visible and processed by the RequestPoolService.

Change-Id: I0b98d69fc3aa61a317944950d14eb93e1737250c
Reviewed-on: http://gerrit.cloudera.org:8080/7118
Reviewed-by: Matthew Jacobs <mj@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Matthew Jacobs: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7118
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b98d69fc3aa61a317944950d14eb93e1737250c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message