impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds
Date Wed, 21 Jun 2017 19:16:29 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds

IMPALA-3040 addendum: use specific_build_type_timeout for slow builds

IMPALA-3040 was initially fixed to use a timeout with HDFS caching
tests, however some test executions against slow-running builds such as
ASAN indicate this timeout may not be high enough.

Use the specific_build_type_timeout() method to set a much higher
timeout for slower builds such as ASAN. This allows us to virtually
ignore timeout values on slow builds, but doesn't force us to
unconditionally increase the timeout in a release or debug build.


Ran all tests that use get_num_cache_requests() in a loop 100 times each
under an ASAN build.  All test iterations passed.

Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Reviewed-by: Michael Brown <>
Tested-by: Impala Public Jenkins
M tests/query_test/
1 file changed, 3 insertions(+), 1 deletion(-)

  Impala Public Jenkins: Verified
  Michael Brown: Looks good to me, approved

To view, visit
To unsubscribe, visit

Gerrit-MessageType: merged
Gerrit-Change-Id: I80f1c8a0e634a3726c53ef7297c5b162dd57a3a2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>

View raw message