impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5549: Remove deprecated fields from CatalogService API
Date Wed, 21 Jun 2017 18:02:22 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5549: Remove deprecated fields from CatalogService API
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Ok, Thanks for clarifying.

http://gerrit.cloudera.org:8080/#/c/7248/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 2916:     }
May be add a Preconditions check on updatedPrivs.size() > 1 just so that it doesn't show
up as an NPE in some edge case? (or) Probably surround the whole block with if (!updatedPrivs.isEmpty())


-- 
To view, visit http://gerrit.cloudera.org:8080/7248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc80e43392cdc85a841e670030e0988692bdf884
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message