impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
Date Wed, 21 Jun 2017 16:39:33 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization
......................................................................


Patch Set 4:

I fixed the placement of WARN_UNUSED_RESULT in the previous patchset, and also changed a method
signature in the parquet writer so that the status of a compression operation could be checked.
Please take another quick look at hdfs-parquet-table-writer.cc!

-- 
To view, visit http://gerrit.cloudera.org:8080/7226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b5a8d2cc315db50e5d70b1191702206de3450d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message