impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5536: Fix TCLIService thrift compilation on Hive 2
Date Wed, 21 Jun 2017 05:30:02 GMT
Tim Armstrong has submitted this change and it was merged.

Change subject: IMPALA-5536: Fix TCLIService thrift compilation on Hive 2
......................................................................


IMPALA-5536: Fix TCLIService thrift compilation on Hive 2

This fixes some issues with Impala compilation on Hive 2:

1. It fixes TCLIService.thrift generation by changing
common/thrift/CMakeLists.txt to create the directory
before generating the file and adding a dependency
to generate TCLIService.thrift before compiling the
thrift files.
2. It modifies CatalogOpExecutor::applyAlterTable to
use the MetastoreShim.

With these changes, Impala builds successfully with
Hive 2 in my environment and on automated builds.

Change-Id: I7e1477993ee3ccddd236609efec7bb23f20a7b66
Reviewed-on: http://gerrit.cloudera.org:8080/7231
Tested-by: Impala Public Jenkins
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
---
M common/thrift/CMakeLists.txt
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
2 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e1477993ee3ccddd236609efec7bb23f20a7b66
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message