impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5548 Fix some minor issues with HDFS / parquet column readers
Date Wed, 21 Jun 2017 04:02:53 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column readers
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7240/1/be/src/exec/hdfs-scan-node-base.h
File be/src/exec/hdfs-scan-node-base.h:

Line 352:   FileFormatsMap per_type_files_;
we iterate through this one. it doesn't look like the ordering has any interesting side effects,
but not sure it's worth introducing the non-determinism since this isn't on a perf critical
path and the number of 'type' (i.e. keys) is small anyway.


Line 464:       std::pair<THdfsFileFormat::type, THdfsCompression::type>, int> FileTypeCountsMap;
we iterate this one to print some info, and it seems like a consistent order makes debugging
a bit easier. And this isn't perf sensitive. So, how about leaving this one ordered?


-- 
To view, visit http://gerrit.cloudera.org:8080/7240
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e653cae6f2188599f4a23e4f44692166d9c119
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message